Summary: | Add hiDPI support for compositing content in DumpRenderTree/WebKitTestRunner | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | zalan <zalan> | ||||||||||||
Component: | Tools / Tests | Assignee: | zalan <zalan> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | benjamin, buildbot, commit-queue, rniwa, simon.fraser | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Bug Depends on: | |||||||||||||||
Bug Blocks: | 129859 | ||||||||||||||
Attachments: |
|
Description
zalan
2014-03-07 22:02:19 PST
Created attachment 226202 [details]
Patch
Comment on attachment 226202 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226202&action=review > Tools/DumpRenderTree/mac/DumpRenderTree.mm:930 > + @"AppleMagnifiedMode": @NO, Probably just remove this. > Tools/WebKitTestRunner/mac/main.mm:34 > + @"AppleMagnifiedMode": @NO, Remove. Comment on attachment 226202 [details] Patch Attachment 226202 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6182253537263616 New failing tests: fast/borders/hidpi-border-clipping-right-after-move.html compositing/hidpi-compositing-vs-non-compositing-check-on-testing-framework.html Created attachment 226203 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Created attachment 226367 [details]
Patch
Comment on attachment 226367 [details]
Patch
EWS testing
Comment on attachment 226367 [details] Patch Attachment 226367 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4791742842798080 New failing tests: svg/custom/masking-clipping-hidpi.svg Created attachment 226388 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Created attachment 226428 [details]
Patch
Comment on attachment 226428 [details]
Patch
EWS testing
Committed r165470: <http://trac.webkit.org/changeset/165470> compositing/hidpi-simple-container-layer-on-device-pixel.html fails since this commit. Can you please have a look (or revert?) (In reply to comment #12) > compositing/hidpi-simple-container-layer-on-device-pixel.html fails since this commit. Can you please have a look (or revert?) thanks. It's ML wk2 debug only, so I'll just skip it for now and will come back to it. (In reply to comment #13) > (In reply to comment #12) > > compositing/hidpi-simple-container-layer-on-device-pixel.html fails since this commit. Can you please have a look (or revert?) > > thanks. It's ML wk2 debug only, so I'll just skip it for now and will come back to it. https://bugs.webkit.org/show_bug.cgi?id=130175 |