Bug 129952

Summary: Web Inspector: AXI: Use loc strings for known aria-invalid types
Product: WebKit Reporter: James Craig <jcraig>
Component: Web InspectorAssignee: James Craig <jcraig>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, jcraig, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 129779, 129943, 130037    
Bug Blocks:    
Attachments:
Description Flags
patch
joepeck: review+, jcraig: commit-queue-
patch (removing minor test case updates to avoid conflicts while commit bot is down) none

Description James Craig 2014-03-07 18:57:52 PST
Web Inspector: AXI: Use loc strings for known aria-invalid types

true -> "Yes"
spelling -> "Spelling"
grammar -> "Grammar"
"false" values will be suppressed. 

Unknown types ("foo") and "false" will all eval to "true" and be exposed as "Yes"…
If there are other types added in ARIA.Next (e.g. aria-invalid="order"), once WebKit recognizes them, we should still pass them through to the client and localize them separately. In other words, don't suppress values that WebKit knows about, even if we don't have a loc string for it yet.
Comment 1 James Craig 2014-03-07 18:59:34 PST
> Unknown types ("foo") and "false" will all eval to "true" and be exposed as "Yes"…

Typo: unknown values will be truthy, but "false" values won't.
Comment 2 James Craig 2014-03-07 23:48:26 PST
This should be updated to use an enum for the inspector protocol, too.
Comment 3 James Craig 2014-03-11 02:55:31 PDT
Created attachment 226409 [details]
patch
Comment 4 James Craig 2014-03-11 02:58:40 PDT
<rdar://problem/16286779>
Comment 5 James Craig 2014-03-12 09:48:50 PDT
Comment on attachment 226409 [details]
patch

cq- b/c I'll need to update the expected test result once bug 129779 lands
Comment 6 Joseph Pecoraro 2014-03-12 10:57:56 PDT
Comment on attachment 226409 [details]
patch

r=me, nice.
Comment 7 James Craig 2014-03-13 16:42:14 PDT
Created attachment 226628 [details]
patch (removing minor test case updates to avoid conflicts while commit bot is down)
Comment 8 WebKit Commit Bot 2014-03-13 19:49:32 PDT
Comment on attachment 226628 [details]
patch (removing minor test case updates to avoid conflicts while commit bot is down)

Clearing flags on attachment: 226628

Committed r165597: <http://trac.webkit.org/changeset/165597>
Comment 9 WebKit Commit Bot 2014-03-13 19:49:35 PDT
All reviewed patches have been landed.  Closing bug.