Summary: | Web Inspector: AXI: Use loc strings for known aria-invalid types | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | James Craig <jcraig> | ||||||
Component: | Web Inspector | Assignee: | James Craig <jcraig> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, graouts, jcraig, joepeck, timothy, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | 129779, 129943, 130037 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
James Craig
2014-03-07 18:57:52 PST
> Unknown types ("foo") and "false" will all eval to "true" and be exposed as "Yes"…
Typo: unknown values will be truthy, but "false" values won't.
This should be updated to use an enum for the inspector protocol, too. Created attachment 226409 [details]
patch
Comment on attachment 226409 [details] patch cq- b/c I'll need to update the expected test result once bug 129779 lands Comment on attachment 226409 [details]
patch
r=me, nice.
Created attachment 226628 [details]
patch (removing minor test case updates to avoid conflicts while commit bot is down)
Comment on attachment 226628 [details] patch (removing minor test case updates to avoid conflicts while commit bot is down) Clearing flags on attachment: 226628 Committed r165597: <http://trac.webkit.org/changeset/165597> All reviewed patches have been landed. Closing bug. |