Bug 129940

Summary: Web Inspector: AXI: Add label string once AccessibilityObject::computedLabel() is available
Product: WebKit Reporter: James Craig <jcraig>
Component: Web InspectorAssignee: James Craig <jcraig>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, graouts, jcraig, jdiggs, joepeck, mario, samuel_white, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 129939    
Bug Blocks:    
Attachments:
Description Flags
patch none

James Craig
Reported 2014-03-07 16:59:42 PST
Web Inspector: AX: Add label to Web AXI once AccessibilityObject::computedLabelString() is available
Attachments
patch (11.61 KB, patch)
2014-08-05 16:15 PDT, James Craig 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Craig
Comment 1 2014-03-14 23:46:57 PDT
ping for importer bot
Radar WebKit Bug Importer
Comment 2 2014-03-14 23:47:16 PDT
<rdar://problem/16334542>
James Craig
Comment 3 2014-03-21 12:17:44 PDT
Until Sam gets a change to work on reconciling all the label code, I might be able to stub this out by implementing AccessibilityNodeObject::computedLabelString() as a wrapper around AccessibilityNodeObject::labelForElement(Element* element)
James Craig
Comment 4 2014-03-21 22:45:44 PDT
No, labelForElement just returns the label element for HTML form controls.
James Craig
Comment 5 2014-08-05 16:15:44 PDT
Created attachment 236063 [details] patch
WebKit Commit Bot
Comment 6 2014-08-05 23:21:20 PDT
Comment on attachment 236063 [details] patch Clearing flags on attachment: 236063 Committed r172136: <http://trac.webkit.org/changeset/172136>
WebKit Commit Bot
Comment 7 2014-08-05 23:21:24 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.