Bug 129940

Summary:

Web Inspector: AXI: Add label string once AccessibilityObject::computedLabel() is available

Product:

WebKit

Reporter:

James Craig <jcraig>

Component:

Web Inspector

Assignee:

James Craig <jcraig>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, graouts, jcraig, jdiggs, joepeck, mario, samuel_white, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

129939

Bug Blocks:

Attachments:

Description	Flags
patch	none

Description James Craig 2014-03-07 16:59:42 PST

Web Inspector: AX: Add label to Web AXI once AccessibilityObject::computedLabelString() is available

Comment 1 James Craig 2014-03-14 23:46:57 PDT

ping for importer bot

Comment 2 Radar WebKit Bug Importer 2014-03-14 23:47:16 PDT

<rdar://problem/16334542>

Comment 3 James Craig 2014-03-21 12:17:44 PDT

Until Sam gets a change to work on reconciling all the label code, I might be able to stub this out by implementing AccessibilityNodeObject::computedLabelString() as a wrapper around AccessibilityNodeObject::labelForElement(Element* element)

Comment 4 James Craig 2014-03-21 22:45:44 PDT

No, labelForElement just returns the label element for HTML form controls.

Comment 5 James Craig 2014-08-05 16:15:44 PDT

Created attachment 236063 [details]
patch

Comment 6 WebKit Commit Bot 2014-08-05 23:21:20 PDT

Comment on attachment 236063 [details]
patch

Clearing flags on attachment: 236063

Committed r172136: <http://trac.webkit.org/changeset/172136>

Comment 7 WebKit Commit Bot 2014-08-05 23:21:24 PDT

All reviewed patches have been landed.  Closing bug.