Bug 129902

Summary: [GTK] Improve ninja detection in webkitdirs.pm
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dbates, jberta.u-szeged, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Martin Robinson
Reported 2014-03-07 12:54:46 PST
We should avoid this spurious output.
Attachments
Patch (1.11 KB, patch)
2014-03-07 12:57 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Patch (1.28 KB, patch)
2014-03-14 19:07 PDT, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2014-03-07 12:57:03 PST
Created attachment 226152 [details] Patch
Daniel Bates
Comment 2 2014-03-13 19:02:28 PDT
This issue was fixed in <http://trac.webkit.org/changeset/165541> (bug #130129). Maybe it would be better to use which(1) to detect whether ninja is in the user's path as opposed to calling ninja and redirecting stderr (thereby silencing the "command not found" error) as in the aforementioned change set?
Csaba Osztrogonác
Comment 3 2014-03-14 01:46:59 PDT
Comment on attachment 226152 [details] Patch It is really better fix than r165541, r=me. (but cq-, because it is in conflict with r165541.)
Martin Robinson
Comment 4 2014-03-14 09:01:49 PDT
I think this is a good bug to switch to 'which' and also to detect ninja-build as well (as it is called on Fedora).
Martin Robinson
Comment 5 2014-03-14 19:07:39 PDT
Created attachment 226790 [details] Patch
Martin Robinson
Comment 6 2014-03-15 15:44:54 PDT
Comment on attachment 226790 [details] Patch Clearing flags on attachment: 226790 Committed r165684: <http://trac.webkit.org/changeset/165684>
Martin Robinson
Comment 7 2014-03-15 15:44:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.