| Summary: | [GTK] Improve ninja detection in webkitdirs.pm | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Martin Robinson <mrobinson> | ||||||
| Component: | WebKitGTK | Assignee: | Martin Robinson <mrobinson> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, dbates, jberta.u-szeged, ossy | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Martin Robinson
2014-03-07 12:54:46 PST
Created attachment 226152 [details]
Patch
This issue was fixed in <http://trac.webkit.org/changeset/165541> (bug #130129). Maybe it would be better to use which(1) to detect whether ninja is in the user's path as opposed to calling ninja and redirecting stderr (thereby silencing the "command not found" error) as in the aforementioned change set? Comment on attachment 226152 [details] Patch It is really better fix than r165541, r=me. (but cq-, because it is in conflict with r165541.) I think this is a good bug to switch to 'which' and also to detect ninja-build as well (as it is called on Fedora). Created attachment 226790 [details]
Patch
Comment on attachment 226790 [details] Patch Clearing flags on attachment: 226790 Committed r165684: <http://trac.webkit.org/changeset/165684> All reviewed patches have been landed. Closing bug. |