Summary: | [GTK] Runtime error when page is closed while print operation is in progress | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | andersca | ||||
Priority: | P2 | Keywords: | Gtk | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Carlos Garcia Campos
2014-03-07 01:49:11 PST
Created attachment 226099 [details]
Patch
Comment on attachment 226099 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226099&action=review GTK+ bits look good to me. I'll leave the rest to the WebKit2 owners. > Source/WebKit2/WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:418 > +void WebPrintOperationGtk::disconnectFromPage() Maybe call this didDisconnectFromPage or notifyDisconnectFromPage since the disconnection actually happens earlier? (In reply to comment #2) > (From update of attachment 226099 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=226099&action=review > > GTK+ bits look good to me. I'll leave the rest to the WebKit2 owners. Thanks for the review. > > Source/WebKit2/WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:418 > > +void WebPrintOperationGtk::disconnectFromPage() > > Maybe call this didDisconnectFromPage or notifyDisconnectFromPage since the disconnection actually happens earlier? I followed other similar existing methods that are disconnectFromPage. This happens when the page is closed, and is telling the print operation to disconnect from the page. It's consistent with WebColorChooser::disconnectFromPage(), WebPopupMenu::disconnectFromPage(), WebOpenPanelResultListener::disconnectFromPage(), etc. Committed r165489: <http://trac.webkit.org/changeset/165489> |