Bug 129858

Summary:

JSGlobalContextRelease incorrectly handles saving/restoring IdentifierTable

Product:

WebKit

Reporter:

Mark Hahnenberg <mhahnenberg>

Component:

JavaScriptCore

Assignee:

Mark Hahnenberg <mhahnenberg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Mark Hahnenberg 2014-03-06 18:27:09 PST

It was correct (but really ugly) prior to the combining of APIEntryShim and JSLock, but now it ends up overwriting the IdentifierTable.

Comment 1 Mark Hahnenberg 2014-03-06 18:27:52 PST

<rdar://problem/15511394>

Comment 2 Mark Hahnenberg 2014-03-06 18:29:57 PST

Created attachment 226073 [details]
Patch

Comment 3 Mark Lam 2014-03-06 18:40:05 PST

Comment on attachment 226073 [details]
Patch

r=me

Comment 4 WebKit Commit Bot 2014-03-06 19:24:10 PST

Comment on attachment 226073 [details]
Patch

Clearing flags on attachment: 226073

Committed r165244: <http://trac.webkit.org/changeset/165244>

Comment 5 WebKit Commit Bot 2014-03-06 19:24:11 PST

All reviewed patches have been landed.  Closing bug.