Bug 129857 – Web Inspector: JSContext inspection - TypeError: null is not an object (evaluating 'contentView.showSourceCode')

• Component: Web Inspector
• Status: RESOLVED FIXED

[Joseph Pecoraro]

There is no "MainFrame" when inspecting a JSContext.

[Error] TypeError: null is not an object (evaluating 'contentView.showSourceCode')
	showMainFrameSourceCode (ResourceSidebarPanel.js, line 123)
	showDefaultContentView (DebuggerSidebarPanel.js, line 134)
	_revealAndSelectRepresentedObjectInNavigationSidebar (Main.js, line 911)
	_updateNavigationSidebarForCurrentContentView (Main.js, line 940)
	_navigationSidebarPanelSelected (Main.js, line 949)
	dispatch (Object.js, line 180)
	dispatchEventToListeners (Object.js, line 187)
	selectedSidebarPanel (Sidebar.js, line 153)
	show (SidebarPanel.js, line 96)
	show (NavigationSidebarPanel.js, line 397)
	_debuggerDidPause (Main.js, line 748)
	dispatch (Object.js, line 180)
	dispatchEventToListeners (Object.js, line 187)
	debuggerDidPause (DebuggerManager.js, line 378)
	paused (DebuggerObserver.js, line 58)
	dispatch (InspectorBackend.js, line 256)
	dispatchNextQueuedMessageFromBackend (MessageDispatcher.js, line 31)
	(anonymous function) ([native code], line 0)

[Joseph Pecoraro]

Created attachment 226074 [details]
[PATCH] Proposed Fix

I'm open to better ideas. This seemed to work okay.

[Joseph Pecoraro]

Comment on attachment 226074 [details]
[PATCH] Proposed Fix

Hmmm, no I think this might break split console toggling.

[Timothy Hatcher]

Comment on attachment 226074 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=226074&action=review

I think this is fine. Only concern I have is the use of this.parentSidebar.selectedSidebarPanel.show().

> Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js:112
> +            this.parentSidebar.selectedSidebarPanel.show();

I am not sure this is right. Why do we need to force the sidebar to show? A comment would be good about why it is forced to show and why this uses this.parentSidebar.selectedSidebarPanel.

> Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js:117
> +        this.parentSidebar.selectedSidebarPanel.show();

Ditto.

[Joseph Pecoraro]

This patch still hasn't landed yet. I still don't like the patch, let me investigate some more.

[Radar WebKit Bug Importer]

<rdar://problem/16530662>

[Joseph Pecoraro]

Created attachment 228642 [details]
[PATCH] Simpler Solution

[Joseph Pecoraro]

Created attachment 228644 [details]
[PATCH] Rebaselined

[WebKit Commit Bot]

Comment on attachment 228644 [details]
[PATCH] Rebaselined

Clearing flags on attachment: 228644

Committed r166824: <http://trac.webkit.org/changeset/166824>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.