Summary: | Web Inspector: JSContext inspection - TypeError: null is not an object (evaluating 'contentView.showSourceCode') | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||||
Component: | Web Inspector | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, graouts, joepeck, timothy, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Joseph Pecoraro
2014-03-06 18:13:44 PST
Created attachment 226074 [details]
[PATCH] Proposed Fix
I'm open to better ideas. This seemed to work okay.
Comment on attachment 226074 [details]
[PATCH] Proposed Fix
Hmmm, no I think this might break split console toggling.
Comment on attachment 226074 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=226074&action=review I think this is fine. Only concern I have is the use of this.parentSidebar.selectedSidebarPanel.show(). > Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js:112 > + this.parentSidebar.selectedSidebarPanel.show(); I am not sure this is right. Why do we need to force the sidebar to show? A comment would be good about why it is forced to show and why this uses this.parentSidebar.selectedSidebarPanel. > Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js:117 > + this.parentSidebar.selectedSidebarPanel.show(); Ditto. This patch still hasn't landed yet. I still don't like the patch, let me investigate some more. Created attachment 228642 [details]
[PATCH] Simpler Solution
Created attachment 228644 [details]
[PATCH] Rebaselined
Comment on attachment 228644 [details] [PATCH] Rebaselined Clearing flags on attachment: 228644 Committed r166824: <http://trac.webkit.org/changeset/166824> All reviewed patches have been landed. Closing bug. |