Bug 129837

Summary: detectFailures in run-jsc-stress-tests can report everything was ok if too many tests fail
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Mark Hahnenberg
Reported 2014-03-06 15:21:38 PST
This is due to the following line: output = sshRead("cd #{$remoteDirectory}/#{$outputDir.basename}/.runner && (ls test_fail_* 2> /dev/null || true)") ls test_fail_* can fail if there are too many files that match. We then swallow that error, which makes everything seem ok. The fix is to use find instead of ls like we do in shell-runner.sh.
Attachments
Patch (1.41 KB, patch)
2014-03-06 15:35 PST, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Patch (1.41 KB, patch)
2014-03-06 17:24 PST, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2014-03-06 15:35:19 PST
Created attachment 226050 [details] Patch
Mark Hahnenberg
Comment 2 2014-03-06 17:24:50 PST
Created attachment 226067 [details] Patch
WebKit Commit Bot
Comment 3 2014-03-06 18:12:54 PST
Comment on attachment 226067 [details] Patch Clearing flags on attachment: 226067 Committed r165239: <http://trac.webkit.org/changeset/165239>
WebKit Commit Bot
Comment 4 2014-03-06 18:12:56 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.