Bug 129829

Summary:

JSC should disable the JIT when building for ARMv7k

Product:

WebKit

Reporter:

Michael Saboff <msaboff>

Component:

JavaScriptCore

Assignee:

Michael Saboff <msaboff>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cmarcelo, commit-queue, ggaren

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	oliver: review+

Description Michael Saboff 2014-03-06 14:46:26 PST

There are calling convention changes in ARMv7k, specifically around where arguments are placed when making a call.  Before that work is done, let's disable the LLInt and JITs, using the C Loop instead for JavaScript.

Comment 1 Michael Saboff 2014-03-06 15:29:36 PST

Created attachment 226048 [details]
Patch

Comment 2 Oliver Hunt 2014-03-06 15:33:10 PST

Comment on attachment 226048 [details]
Patch

holy shit how many arms are there???

Comment 3 Michael Saboff 2014-03-06 15:35:34 PST

Committed r165225: <http://trac.webkit.org/changeset/165225>

Comment 4 Geoffrey Garen 2014-03-06 16:08:48 PST

> holy shit how many arms are there???

                       ___
                    .-'   `'.
                   /         \
                   |         ;
                   |         |           ___.--,
          _.._     |0) ~ (0) |    _.---'`__.-( (_.
   __.--'`_.. '.__.\    '--. \_.-' ,.--'`     `""`
  ( ,.--'`   ',__ /./;   ;, '.__.'`    __
  _`) )  .---.__.' / |   |\   \__..--""  """--.,_
 `---' .'.''-._.-'`_./  /\ '.  \ _.-~~~````~~~-._`-.__.'
       | |  .' _.-' |  |  \  \  '.               `~---`
        \ \/ .'     \  \   '. '-._)
         \/ /        \  \    `=.__`~-.
         / /\         `) )    / / `"".`\
   , _.-'.'\ \        / /    ( (     / /
    `--~`   ) )    .-'.'      '.'.  | (
           (/`    ( (`          ) )  '-;
            `      '-;         (-'