Bug 129806

Summary: Clarify how we deal with "special" registers
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, commit-queue, ggaren, mark.lam, mhahnenberg, mmirman, msaboff, nrotem, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 129822    
Bug Blocks: 112840    
Attachments:
Description Flags
the patch
none
the patch msaboff: review+

Description Filip Pizlo 2014-03-06 09:46:12 PST
What is "special" anyway?  Nobody knows!  This bug aims to fix that.
Comment 1 Filip Pizlo 2014-03-06 09:51:25 PST
Created attachment 226001 [details]
the patch
Comment 2 Filip Pizlo 2014-03-06 09:53:12 PST
Created attachment 226002 [details]
the patch
Comment 3 Michael Saboff 2014-03-06 09:58:23 PST
Comment on attachment 226002 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226002&action=review

r=me

> Source/JavaScriptCore/ChangeLog:16
> +        you also have to wrory about the LR register, which we'd want to say is "not real" but it's

*worry*
Comment 4 Filip Pizlo 2014-03-06 10:27:50 PST
Landed in http://trac.webkit.org/changeset/165196
Comment 5 WebKit Commit Bot 2014-03-06 13:13:58 PST
Re-opened since this is blocked by bug 129822
Comment 6 Michael Saboff 2014-03-07 14:17:05 PST
Committed r165293: <http://trac.webkit.org/changeset/165293>