Bug 129801

Summary: [CMake][GTK] Add missing references to DOMURLMediaStream
Product: WebKit Reporter: Lorenzo Tilve <ltilve>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, commit-queue, gyuyoung.kim, mrobinson, rakuco, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Lorenzo Tilve
Reported 2014-03-06 07:29:22 PST
Building WebKitGTK with --gtkcmake --cmakeargs="-GNinja" is returning an error due to an undefined reference to WebCore::DOMURLMediaStream::createObjectURL [10/119] Linking CXX shared library lib/libwebkit2gtk-3.0.so.25.7.0 FAILED: : && /usr/lib/ccache/c++ -fPIC -std=gnu++0x -fno-omit-frame-pointer -fno-tree-dce -O3 -DNDEBUG -Wl,--no-undefined -shared -Wl,-soname,libwebkitgtk-3.0.so.0 -o lib/libwebkitgtk-3.0.so.0.22.0 @CMakeFiles/WebKit.rsp && : lib/../Source/WebCore/CMakeFiles/WebCore.dir/__/__/DerivedSources/WebCore/JSDOMURL.cpp.o: In function `WebCore::jsDOMURLConstructorFunctionCreateObjectURL(JSC::ExecState*)': JSDOMURL.cpp:(.text+0x671): undefined reference to `WebCore::DOMURLMediaStream::createObjectURL(WebCore::ScriptExecutionContext*, WebCore::MediaStream*)' collect2: error: ld returned 1 exit status
Attachments
Patch (1.66 KB, patch)
2014-03-06 07:33 PST, Lorenzo Tilve 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Lorenzo Tilve
Comment 1 2014-03-06 07:33:47 PST
Created attachment 225991 [details] Patch
Martin Robinson
Comment 2 2014-03-06 07:37:01 PST
Comment on attachment 225991 [details] Patch Thanks!
WebKit Commit Bot
Comment 3 2014-03-06 08:08:07 PST
Comment on attachment 225991 [details] Patch Clearing flags on attachment: 225991 Committed r165192: <http://trac.webkit.org/changeset/165192>
WebKit Commit Bot
Comment 4 2014-03-06 08:08:11 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.