Summary: | Fix the !ENABLE(CSS_STICKY_POSITION) build | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Zsolt Borbely <zsborbely.u-szeged> | ||||||
Component: | CSS | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, lucas.de.marchi, mmaxfield, ossy, rtakacs, simon.fraser, thorton | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Zsolt Borbely
2014-03-06 02:13:17 PST
Created attachment 225972 [details]
Proposed patch
It isn't related to EFL, you will get same build failure on all ports if you try to disable CSS Sticky Position. cc-ing Myles and Simon, the author and the reviewer of - https://trac.webkit.org/changeset/163916 - https://trac.webkit.org/changeset/164299 Created attachment 225988 [details]
Proposed patch
Comment on attachment 225988 [details]
Proposed patch
Why does EFL not want sticky enabled?
(In reply to comment #5) > (From update of attachment 225988 [details]) > Why does EFL not want sticky enabled? It is enabled by default on EFL, but the guard should work properly. Comment on attachment 225988 [details] Proposed patch Clearing flags on attachment: 225988 Committed r165198: <http://trac.webkit.org/changeset/165198> All reviewed patches have been landed. Closing bug. (In reply to comment #6) > (In reply to comment #5) > > (From update of attachment 225988 [details] [details]) > > Why does EFL not want sticky enabled? > > It is enabled by default on EFL, but the guard should work properly. It's a small feature that everyone has enabled (as far as I know); maybe we should get rid of the guard? Thanks for fixing this. It was my fault. |