Bug 129790

Summary: [Mac] Always do a full GC when simulating memory pressure.
Product: WebKit Reporter: Andreas Kling <kling>
Component: WebCore JavaScriptAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ggaren, kling, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ggaren: review-
Patch
ggaren: review-
Patch none

Andreas Kling
Reported 2014-03-06 01:31:24 PST
We should call releaseExecutableMemory() when under memory pressure.
Attachments
Patch (2.21 KB, patch)
2014-03-06 01:36 PST, Andreas Kling 		ggaren: review-
DetailsFormatted DiffDiff
Patch (1.58 KB, patch)
2014-04-08 12:03 PDT, Andreas Kling 		ggaren: review-
DetailsFormatted DiffDiff
Patch (1.75 KB, patch)
2014-04-08 12:45 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2014-03-06 01:36:42 PST
Created attachment 225967 [details] Patch
Geoffrey Garen
Comment 2 2014-03-06 09:41:42 PST
Comment on attachment 225967 [details] Patch I don't think we can afford to do this :(. The cost of GC under memory pressure is just too high. Can we throw away code without forcing a GC?
Andreas Kling
Comment 3 2014-04-08 12:03:45 PDT
Created attachment 228864 [details] Patch
Geoffrey Garen
Comment 4 2014-04-08 12:29:26 PDT
Comment on attachment 228864 [details] Patch /Volumes/Data/EWS/WebKit/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm:76:9: error: use of undeclared identifier 'gcController' gcController().garbageCollectNow(); ^
Andreas Kling
Comment 5 2014-04-08 12:45:33 PDT
Created attachment 228871 [details] Patch
Geoffrey Garen
Comment 6 2014-04-08 12:46:36 PDT
Comment on attachment 228871 [details] Patch r=me
WebKit Commit Bot
Comment 7 2014-04-08 13:27:20 PDT
Comment on attachment 228871 [details] Patch Clearing flags on attachment: 228871 Committed r166953: <http://trac.webkit.org/changeset/166953>
WebKit Commit Bot
Comment 8 2014-04-08 13:27:23 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.