Bug 129790

Summary: [Mac] Always do a full GC when simulating memory pressure.
Product: WebKit Reporter: Andreas Kling <kling>
Component: WebCore JavaScriptAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ggaren, kling, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ggaren: review-
Patch
ggaren: review-
Patch none

Description Andreas Kling 2014-03-06 01:31:24 PST 
We should call releaseExecutableMemory() when under memory pressure.
Comment 1 Andreas Kling 2014-03-06 01:36:42 PST 
Created attachment 225967 [details]
Patch
Comment 2 Geoffrey Garen 2014-03-06 09:41:42 PST 
Comment on attachment 225967 [details]
Patch

I don't think we can afford to do this :(. The cost of GC under memory pressure is just too high.

Can we throw away code without forcing a GC?
Comment 3 Andreas Kling 2014-04-08 12:03:45 PDT 
Created attachment 228864 [details]
Patch
Comment 4 Geoffrey Garen 2014-04-08 12:29:26 PDT 
Comment on attachment 228864 [details]
Patch

/Volumes/Data/EWS/WebKit/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm:76:9: error: use of undeclared identifier 'gcController'
        gcController().garbageCollectNow();
        ^
Comment 5 Andreas Kling 2014-04-08 12:45:33 PDT 
Created attachment 228871 [details]
Patch
Comment 6 Geoffrey Garen 2014-04-08 12:46:36 PDT 
Comment on attachment 228871 [details]
Patch

r=me
Comment 7 WebKit Commit Bot 2014-04-08 13:27:20 PDT 
Comment on attachment 228871 [details]
Patch

Clearing flags on attachment: 228871

Committed r166953: <http://trac.webkit.org/changeset/166953>
Comment 8 WebKit Commit Bot 2014-04-08 13:27:23 PDT 
All reviewed patches have been landed.  Closing bug.