Bug 129778

Summary: GetById list caching should use something object-oriented rather than PolymorphicAccessStructureList
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, bunhere, commit-queue, ggaren, gyuyoung.kim, mark.lam, mhahnenberg, mmirman, msaboff, nrotem, oliver, ossy, rakuco, sam, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 129591, 130134    
Bug Blocks: 129589, 129590    
Attachments:
Description Flags
work in progress
none
it compiles
none
starting to work
none
almost done
none
the patch ggaren: review+

Description Filip Pizlo 2014-03-05 21:55:52 PST 
...
Comment 1 Filip Pizlo 2014-03-10 19:11:33 PDT 
Created attachment 226366 [details]
work in progress
Comment 2 Filip Pizlo 2014-03-10 19:24:45 PDT 
Created attachment 226369 [details]
it compiles

Not done yet though.
Comment 3 Filip Pizlo 2014-03-10 20:07:59 PDT 
Created attachment 226376 [details]
starting to work
Comment 4 Filip Pizlo 2014-03-10 21:21:16 PDT 
Created attachment 226382 [details]
almost done
Comment 5 Filip Pizlo 2014-03-10 23:48:55 PDT 
Created attachment 226393 [details]
the patch
Comment 6 WebKit Commit Bot 2014-03-10 23:51:42 PDT 
Attachment 226393 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/PolymorphicGetByIdList.h:104:  The parameter name "stubInfo" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/bytecode/StructureStubInfo.h:51:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/JavaScriptCore/bytecode/PolymorphicGetByIdList.cpp:41:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/PolymorphicGetByIdList.cpp:42:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/PolymorphicGetByIdList.cpp:43:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/PolymorphicGetByIdList.cpp:44:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
Total errors found: 6 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Geoffrey Garen 2014-03-11 09:45:20 PDT 
Comment on attachment 226393 [details]
the patch

r=me
Comment 8 Filip Pizlo 2014-03-11 20:43:53 PDT 
Landed in http://trac.webkit.org/changeset/165459
Comment 9 Csaba Osztrogonác 2014-03-12 09:26:56 PDT 
(In reply to comment #8)
> Landed in http://trac.webkit.org/changeset/165459

It caused regression on ARM Thumb2 - https://bugs.webkit.org/show_bug.cgi?id=130134
Comment 10 Csaba Osztrogonác 2014-03-14 03:27:47 PDT 
(In reply to comment #9)
> (In reply to comment #8)
> > Landed in http://trac.webkit.org/changeset/165459
> 
> It caused regression on ARM Thumb2 - https://bugs.webkit.org/show_bug.cgi?id=130134

Same regression occured on 32 bit Apple Mac build too.
But https://bugs.webkit.org/show_bug.cgi?id=130203
fixed 94 failures from the 110 , only 16 failures remains.
Comment 11 Filip Pizlo 2014-08-25 21:12:58 PDT 
*** Bug 129590 has been marked as a duplicate of this bug. ***