| Summary: | Subpixel rendering: Setting content to opaque on m_graphicsLayer depends on subpixel accumulation. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, esprehn+autocc, glenn, kondapallykalyan, simon.fraser | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
Created attachment 225951 [details]
Patch
Should find a way to test it :( Created attachment 225986 [details]
Patch
Comment on attachment 225986 [details] Patch Clearing flags on attachment: 225986 Committed r165190: <http://trac.webkit.org/changeset/165190> All reviewed patches have been landed. Closing bug. |
diff --git a/Source/WebCore/rendering/RenderLayerBacking.cpp b/Source/WebCore/rendering/RenderLayerBacking.cpp index 2528ffa..68c9465 100644 --- a/Source/WebCore/rendering/RenderLayerBacking.cpp +++ b/Source/WebCore/rendering/RenderLayerBacking.cpp @@ -819,7 +819,7 @@ void RenderLayerBacking::updateGraphicsLayerGeometry() if (!m_isMainFrameRenderViewLayer) { // For non-root layers, background is always painted by the primary graphics layer. ASSERT(!m_backgroundLayer); - bool hadSubpixelRounding = !m_devicePixelFractionFromRenderer.isEmpty(); + bool hadSubpixelRounding = !m_devicePixelFractionFromRenderer.isZero(); m_graphicsLayer->setContentsOpaque(!hadSubpixelRounding && m_owningLayer.backgroundIsKnownToBeOpaqueInRect(localCompositingBounds)); }