Bug 129773

Summary: [iOS] Rename the actualVisibleXXXRect to unobscuredContentRect for consistency
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kangil.han, kondapallykalyan, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Benjamin Poulain
Reported 2014-03-05 19:47:53 PST
[iOS] Rename the actualVisibleXXXRect to unoscuredContentRect for consistency
Attachments
Patch (6.89 KB, patch)
2014-03-05 19:48 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (6.90 KB, patch)
2014-03-05 21:15 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2014-03-05 19:48:10 PST
Created attachment 225943 [details] Patch
Daniel Bates
Comment 2 2014-03-05 20:53:18 PST
Comment on attachment 225943 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225943&action=review > Source/WebCore/ChangeLog:3 > + [iOS] Rename the actualVisibleXXXRect to unoscuredContentRect for consistency I take it you mean unobscuredContentRect. Note, you used "unoscured" (sic) throughout this patch.
Benjamin Poulain
Comment 3 2014-03-05 21:02:37 PST
(In reply to comment #2) > (From update of attachment 225943 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=225943&action=review > > > Source/WebCore/ChangeLog:3 > > + [iOS] Rename the actualVisibleXXXRect to unoscuredContentRect for consistency > > I take it you mean unobscuredContentRect. > > Note, you used "unoscured" (sic) throughout this patch. ahahah, the joy of copy-paste :) I'll update :)
Benjamin Poulain
Comment 4 2014-03-05 21:15:40 PST
Created attachment 225949 [details] Patch
Benjamin Poulain
Comment 5 2014-03-06 13:45:31 PST
Comment on attachment 225949 [details] Patch Clearing flags on attachment: 225949 Committed r165211: <http://trac.webkit.org/changeset/165211>
Benjamin Poulain
Comment 6 2014-03-06 13:45:33 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.