Summary: | llint_slow_path_check_has_instance() should not adjust PC before accessing operands | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||
Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | chai, commit-queue, fpizlo, ggaren, mhahnenberg, mmirman, msaboff, oliver | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Mark Lam
2014-03-05 18:06:36 PST
Created attachment 225934 [details]
the patch.
You should audit the other uses of LLINT_RETURN to make sure we're not doing this in any other places. (In reply to comment #2) > You should audit the other uses of LLINT_RETURN to make sure we're not doing this in any other places. Already did. I audited adjustments made to the pc and made sure that they did not precede a LLINT_RETURN(). Attachment 225934 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:125: __r_returnValue is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
Total errors found: 1 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #3) > (In reply to comment #2) > > You should audit the other uses of LLINT_RETURN to make sure we're not doing this in any other places. > > Already did. I audited adjustments made to the pc and made sure that they did not precede a LLINT_RETURN(). Cool :-) Comment on attachment 225934 [details]
the patch.
r=me
Comment on attachment 225934 [details] the patch. Clearing flags on attachment: 225934 Committed r165162: <http://trac.webkit.org/changeset/165162> All reviewed patches have been landed. Closing bug. |