Bug 129754

Summary:

JSObject::fastGetOwnPropertySlot does a slow check for OverridesGetOwnPropertySlot

Product:

WebKit

Reporter:

Mark Hahnenberg <mhahnenberg>

Component:

JavaScriptCore

Assignee:

Mark Hahnenberg <mhahnenberg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Mark Hahnenberg 2014-03-05 13:19:56 PST

It should just use the InlineTypeFlags in JSCell.

Comment 1 Mark Hahnenberg 2014-03-05 13:21:05 PST

Created attachment 225907 [details]
Patch

Comment 2 Geoffrey Garen 2014-03-05 13:26:31 PST

Comment on attachment 225907 [details]
Patch

r=me

Is speedup?

Comment 3 Mark Hahnenberg 2014-03-05 18:54:11 PST

(In reply to comment #2)
> (From update of attachment 225907 [details])
> r=me
> 
> Is speedup?

Doesn't affect any of the usual benchmarks, although that's not surprising since we didn't see a regression from it after 32-bit structures.

Comment 4 WebKit Commit Bot 2014-03-05 19:14:56 PST

Comment on attachment 225907 [details]
Patch

Clearing flags on attachment: 225907

Committed r165164: <http://trac.webkit.org/changeset/165164>

Comment 5 WebKit Commit Bot 2014-03-05 19:15:03 PST

All reviewed patches have been landed.  Closing bug.