Bug 129754

Summary: JSObject::fastGetOwnPropertySlot does a slow check for OverridesGetOwnPropertySlot
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Mark Hahnenberg
Reported 2014-03-05 13:19:56 PST
It should just use the InlineTypeFlags in JSCell.
Attachments
Patch (4.06 KB, patch)
2014-03-05 13:21 PST, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2014-03-05 13:21:05 PST
Created attachment 225907 [details] Patch
Geoffrey Garen
Comment 2 2014-03-05 13:26:31 PST
Comment on attachment 225907 [details] Patch r=me Is speedup?
Mark Hahnenberg
Comment 3 2014-03-05 18:54:11 PST
(In reply to comment #2) > (From update of attachment 225907 [details]) > r=me > > Is speedup? Doesn't affect any of the usual benchmarks, although that's not surprising since we didn't see a regression from it after 32-bit structures.
WebKit Commit Bot
Comment 4 2014-03-05 19:14:56 PST
Comment on attachment 225907 [details] Patch Clearing flags on attachment: 225907 Committed r165164: <http://trac.webkit.org/changeset/165164>
WebKit Commit Bot
Comment 5 2014-03-05 19:15:03 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.