Bug 129752

Summary:

ObjC exception when dropping files into a WKView: drag and drop uses code from WebKit.framework

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

New Bugs

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

enrica, sam, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	enrica: review+

Description Simon Fraser (smfr) 2014-03-05 11:51:09 PST

ObjC exception when dropping files into a WKView: drag and drop uses code from WebKit.framework

Comment 1 Simon Fraser (smfr) 2014-03-05 11:51:39 PST

<rdar://problem/9197507>

Comment 2 Simon Fraser (smfr) 2014-03-05 11:54:27 PST

Created attachment 225897 [details]
Patch

Comment 3 Enrica Casucci 2014-03-05 12:02:42 PST

Comment on attachment 225897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=225897&action=review

Looks good

> Source/WebCore/platform/mac/WebCoreNSURLExtras.mm:722
> +    NSURLRequest *request = [[NSURLRequest alloc] initWithURL:URL];

RetainPtr and avoid release?

> Source/WebCore/platform/mac/WebCoreNSURLExtras.mm:920
> +            */

Comment style

> Source/WebCore/platform/mac/WebCoreNSURLExtras.mm:934
> +    return rangeOfURLScheme(stringByTrimmingWhitespace(string)).location != NSNotFound;

Maybe you could use CFStringTrimWhitespace.

Comment 4 Simon Fraser (smfr) 2014-03-05 12:10:57 PST

https://trac.webkit.org/r165118