Bug 129750

Summary:

WebCrypto HmacKeyParams.length is now bits, not bytes

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, buildbot, commit-queue, esprehn+autocc, iseki.m.aa, jiewen_tan, kangil.han, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=163718

Bug Depends on:

Bug Blocks:

160894

Attachments:

Description	Flags
Patch	ap: review-
TestResults.pdf	none

Alexey Proskuryakov

Reported 2014-03-05 11:38:38 PST

The spec has changed, WebCrypto HmacKeyParams.length is now in bits, not bytes. This makes it consistent with other lengths.

Attachments
Patch (10.35 KB, patch) 2014-11-03 01:49 PST, iseki	ap: review-	Details Formatted Diff Diff
TestResults.pdf (244.92 KB, application/pdf) 2014-11-03 02:00 PST, iseki	no flags	Details
View All Add attachment proposed patch, testcase, etc.

iseki

Comment 1 2014-11-03 01:49:53 PST

Created attachment 240835 [details] Patch

WebKit Commit Bot

Comment 2 2014-11-03 01:51:45 PST

Attachment 240835 [details] did not pass style-queue: ERROR: LayoutTests/ChangeLog:6: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebCore/dom/ExceptionCode.h:64: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 3 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.

iseki

Comment 3 2014-11-03 02:00:53 PST

Created attachment 240836 [details] TestResults.pdf This file is the result of the commonad "./Tools/Scripts/run-webkit-tests -q /$USER_PATH/WebKit/LayoutTests/crypto/subtle/l"

iseki

Comment 4 2014-11-03 02:36:16 PST

Sorry, please ignore the patch at Comment2. I should not add new error code into DOMCoreExceprion. @Alexey Proskuryakov I'm new to WebKit. Would you mind helping me to fix this bug? I think I should make new ExceptionFile like IDBDatabaseException[1] to handle DATA_ERR. [1]https://trac.webkit.org/browser/trunk/Source/WebCore/Modules/indexeddb/IDBDatabaseException.h

Alexey Proskuryakov

Comment 5 2014-11-03 09:13:01 PST

Comment on attachment 240835 [details] Patch We already shipped it like this, so we can't just fix it without aligning with the rest of the spec, and removing webkit prefix. Otherwise, there is no good way for JS code to know what units the length is in.

iseki

Comment 6 2014-11-03 14:50:08 PST

Thank you for your answering. Is there plan to remove WebKit prefix?

Alexey Proskuryakov

Comment 7 2014-11-03 15:02:07 PST

I don't think that anyone is working on this now. It may be best to start a parallel implementation under an #if, and enable it when done. There were so many changes in the spec since last year that it should be easier to implement it from scratch than to fix the old implementation.

Radar WebKit Bug Importer

Comment 8 2016-08-15 17:45:59 PDT

<rdar://problem/27857924>

Jiewen Tan

Comment 9 2016-10-24 23:12:39 PDT

This bug is fixed by Bug 163718.

Note You need to log in before you can comment on or make changes to this bug.