Summary: | [GTK] MiniBrowser crashes when opening several urls passed as command line options | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | svillar | ||||
Priority: | P2 | Keywords: | Gtk | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Carlos Garcia Campos
2014-03-05 05:31:29 PST
Created attachment 225875 [details]
Patch
Comment on attachment 225875 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225875&action=review r=me with comments > Tools/MiniBrowser/gtk/main.c:286 > + g_object_unref(webkitSettings); I'd prefer using g_clear_object(&webkitSettings); We could do the same above when we do: if (!addSettingsGroupToContext(context, webkitSettings)) { g_object_unref(webkitSettings); webkitSettings = 0; } Committed r165181: <http://trac.webkit.org/changeset/165181> |