Bug 129720

Summary: Streamline JSValue::get().
Product: WebKit Reporter: Andreas Kling <kling>
Component: JavaScriptCoreAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: kling, mhahnenberg
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ggaren: review+

Andreas Kling
Reported 2014-03-04 17:54:44 PST
Streamline JSValue::get() to avoid fetching Structure and VM repeatedly.
Attachments
Patch (5.11 KB, patch)
2014-03-04 17:56 PST, Andreas Kling 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2014-03-04 17:56:08 PST
Created attachment 225834 [details] Patch
Geoffrey Garen
Comment 2 2014-03-04 18:09:23 PST
Comment on attachment 225834 [details] Patch Can you make vm and structure arguments 2 and 3, instead of the last two arguments? The last argument is the output, and I'd like to distinguish the input values from the output value.
Andreas Kling
Comment 3 2014-03-04 18:29:35 PST
Committed r165090: <http://trac.webkit.org/changeset/165090>
Note You need to log in before you can comment on or make changes to this bug.