Bug 129707

Summary: [iOS][MediaControls] Reverse-pinching using the built-in controls should enter full screen
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, commit-queue, eric.carlson, glenn, philipj, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
eric.carlson: review+
Patch for landing commit-queue: commit-queue-

Jer Noble
Reported 2014-03-04 14:31:59 PST
[iOS][MediaControls] Reverse-pinching using the built-in controls should enter full screen
Attachments
Patch (3.52 KB, patch)
2014-03-04 14:35 PST, Jer Noble 		eric.carlson: review+
DetailsFormatted DiffDiff
Patch for landing (3.22 KB, patch)
2014-03-10 10:20 PDT, Jer Noble 		commit-queue: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2014-03-04 14:35:08 PST
Created attachment 225817 [details] Patch
Eric Carlson
Comment 2 2014-03-04 14:42:01 PST
Comment on attachment 225817 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225817&action=review > Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js:265 > + handlePlayButtonTouchEnd: function(event) {  Garbage character?
Jer Noble
Comment 3 2014-03-10 10:20:52 PDT
Created attachment 226316 [details] Patch for landing
WebKit Commit Bot
Comment 4 2014-03-14 10:26:41 PDT
Comment on attachment 226316 [details] Patch for landing Rejecting attachment 226316 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 226316, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/6579497612607488
Jer Noble
Comment 5 2014-03-19 14:39:25 PDT
Committed r165919: <http://trac.webkit.org/changeset/165919>
Note You need to log in before you can comment on or make changes to this bug.