Bug 129701

Summary: WinCairo doesn't build without MEDIA_CONTROLS_SCRIPT enabled
Product: WebKit Reporter: Alex Christensen <alex.christensen>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, esprehn+autocc, glenn, jer.noble, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Alex Christensen 2014-03-04 13:40:52 PST 
Here are some fixes to the build system.

I also enabled MEDIA_SOURCE on Windows, but it didn't fix my problem.  Would anyone else be interested in me upstreaming that work?
Comment 1 Alex Christensen 2014-03-04 13:42:20 PST 
Created attachment 225810 [details]
Patch
Comment 2 Alex Christensen 2014-03-04 14:29:50 PST 
Comment on attachment 225810 [details]
Patch

make-js-file-arrays.py should not be changed.  DerivedSources.make should add an if statement to not run it if USER_AGENT_SCRIPTS is empty
Comment 3 Alex Christensen 2014-03-04 15:21:47 PST 
Created attachment 225822 [details]
Patch
Comment 4 Jer Noble 2014-03-04 15:45:51 PST 
Comment on attachment 225822 [details]
Patch

r=me
Comment 5 WebKit Commit Bot 2014-03-04 16:28:13 PST 
Comment on attachment 225822 [details]
Patch

Clearing flags on attachment: 225822

Committed r165084: <http://trac.webkit.org/changeset/165084>
Comment 6 WebKit Commit Bot 2014-03-04 16:28:16 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Brent Fulgham 2014-04-02 17:14:01 PDT 
This patch broke Apple Windows builds when the build directory was deleted. UserAgentScripts.h is not getting generated.
Comment 8 Alex Christensen 2014-04-02 21:07:18 PDT 
It may also have been https://bugs.webkit.org/show_bug.cgi?id=130597 that broke it.

I'm trying to support the WinCairo build with and without VIDEO enabled, which depends on MEDIA_CONTROLS_SCRIPT and VIDEO_TRACK