Bug 129698 – ASSERT Failure: stringImpl.length() > 1 in JSString.h

• Component: JavaScriptCore
• Status: RESOLVED WORKSFORME

[Michael Saboff]

This ASSERT (and preceding comment)
        // Should have picked a VM-global empty or single-character string already.
        ASSERT(stringImpl.length() > 1);
isn't accurate.  The ASSERT should be updated to handle the case where we have a single character string with the characters value greater than JSC::maxSingleCharacterString (currently 255).

[Michael Saboff]

Created attachment 225809 [details]
Patch

[Geoffrey Garen]

Comment on attachment 225809 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 225809 [details]
Patch

Rejecting attachment 225809 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 225809, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
Garen']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 2 diffs from patch file(s).
patching file Source/JavaScriptCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/JavaScriptCore/runtime/JSString.h
Hunk #1 FAILED at 416.
1 out of 1 hunk FAILED -- saving rejects to file Source/JavaScriptCore/runtime/JSString.h.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Geoffrey Garen']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/4558849583349760

[Michael Saboff]

akling fixed this by removing the ASSERT in r165066.