Bug 129683

Summary: Web Inspector: build: InspectorJSTypeBuilders.h breaks strict-aliasing rules
Product: WebKit Reporter: Patrick Welche <prlw1>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: NEW ---    
Severity: Normal CC: berto, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 129799    
Attachments:
Description Flags
Sticking plaster to fix build none

Description Patrick Welche 2014-03-04 07:14:52 PST
./DerivedSources/JavaScriptCore/InspectorJSTypeBuilders.h:116:66: warning: deref
erencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing
]
             return *reinterpret_cast<RefPtr<Location>*>(&m_result);


It looks as though that header is careful about trying to only cast compatible objects.

Need some unions or a sprinkling of -fno-strict-aliasing ?

This is using the recent webkitgtk-2.3.91 tarball.
Comment 1 Patrick Welche 2014-03-06 05:27:36 PST
Created attachment 225981 [details]
Sticking plaster to fix build

This patch gets webkitgtk-2.3.91 building a bit further. Given that the type punning seems intentional, maybe a more legal way of doing it involving unions should be sought. Suggest applying said patch, and leaving bug open.