Bug 129679

Summary: [GTK] Build the Udis86 disassembler
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, berto, bunhere, cmarcelo, commit-queue, gustavo, gyuyoung.kim, mrobinson, rakuco, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Zan Dobersek 2014-03-04 04:42:39 PST 
[GTK] Build the Udis86 disassembler
Comment 1 Zan Dobersek 2014-03-04 04:49:03 PST 
Created attachment 225768 [details]
Patch
Comment 2 Martin Robinson 2014-03-04 08:29:44 PST 
Comment on attachment 225768 [details]
Patch

The patch is missing CMake support, no?
Comment 3 Zan Dobersek 2014-03-04 12:06:25 PST 
Comment on attachment 225768 [details]
Patch

Clearing flags on attachment: 225768

Committed r165067: <http://trac.webkit.org/changeset/165067>
Comment 4 Zan Dobersek 2014-03-04 12:06:37 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Martin Robinson 2014-03-04 13:12:32 PST 
Oh sorry. I see the cmake changes now. I think this really needs a bit more discussion among GTK+ port maintainers though. Is the Udis86 disassembler feature considered stable and mandatory. This patch enables it for releases, which is kid of risky.
Comment 6 Zan Dobersek 2014-03-04 13:56:06 PST 
(In reply to comment #5)
> Oh sorry. I see the cmake changes now. I think this really needs a bit more discussion among GTK+ port maintainers though. Is the Udis86 disassembler feature considered stable and mandatory. This patch enables it for releases, which is kid of risky.

I missed your comment, but the CMake parts were there.

The disassembler doesn't reach deep into JSC and only dumps when using the JSC showDisassembly option (which is present and usable to a point in release builds) but I agree it's probably not useful in release builds.

With CMake the disassembler can be configured to build by simply using -DWTF_USE_UDIS86 in the cmake command. With autotools this could possibly be switchable with a configuration flag or something similar.

If we're throwing autotools support out soon enough this is pretty simple to resolve, otherwise I'll look into enhancing autotools.
Comment 7 Zan Dobersek 2014-03-04 14:08:57 PST 
Actually it should be simple enough to keep the Udis86 building only for the CMake build. I'll conjure something up.
Comment 8 Martin Robinson 2014-03-04 14:56:54 PST 
(In reply to comment #6)

> The disassembler doesn't reach deep into JSC and only dumps when using the JSC showDisassembly option (which is present and usable to a point in release builds) but I agree it's probably not useful in release builds.


Thanks! That actually clears it up for me. From what you are saying, if I understand it correctly, the best course of action is to just disable it when building in production mode for CMake. I can handle that or, if you like, you can write another patch that just does this based on whether production mode is enabled in OptionsGTK.cmake.