Bug 129650

Summary: Merge API shims and JSLock
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, bunhere, commit-queue, ggaren, gyuyoung.kim, jsbell, rakuco, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mark.lam: review+

Mark Hahnenberg
Reported 2014-03-03 19:18:35 PST
There can be only one!
Attachments
Patch (78.65 KB, patch)
2014-03-04 10:41 PST, Mark Hahnenberg 		mark.lam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2014-03-04 10:41:47 PST
Created attachment 225790 [details] Patch
WebKit Commit Bot
Comment 2 2014-03-04 10:42:57 PST
Attachment 225790 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/JSLock.cpp:260: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/JSLock.h:52: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 2 in 33 files If any of these errors are false positives, please file a bug against check-webkit-style.
Mark Lam
Comment 3 2014-03-04 11:10:33 PST
Comment on attachment 225790 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225790&action=review Nice. r=me with minor fix. > Source/JavaScriptCore/runtime/JSLock.cpp:142 > + m_entryIdentifierTable = wtfThreadData().setCurrentIdentifierTable(m_vm->identifierTable); "wtfThreadData()" ==> "threadData".
Mark Hahnenberg
Comment 4 2014-03-04 13:32:39 PST
Committed r165074: <http://trac.webkit.org/changeset/165074>
Note You need to log in before you can comment on or make changes to this bug.