Bug 129645

Summary: Web Inspector: Match color of regex in source view with a popover
Product: WebKit Reporter: Jonathan Wells <jonowells>
Component: Web InspectorAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[TEST] popover test case
none
[SCREENSHOT] before patch
none
[PATCH] Proposed fix none

Jonathan Wells
Reported 2014-03-03 17:10:37 PST
Created attachment 225717 [details] [TEST] popover test case The color for a regular expression in a source popover should be the same orange color that codemirror uses in the source view. * STEPS TO REPRODUCE 1. Open the attached test case 2. Hover variable "regex" which holds a RegExp. => expected color of regexp to be the same orange color as it appears in the source in the assignment on line 7.
Attachments
[TEST] popover test case (435 bytes, text/html)
2014-03-03 17:10 PST, Jonathan Wells 		no flags
Details
[SCREENSHOT] before patch (31.22 KB, image/png)
2014-03-03 17:11 PST, Jonathan Wells 		no flags
Details
[PATCH] Proposed fix (1.36 KB, patch)
2014-03-03 20:35 PST, Jonathan Wells 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-03-03 17:11:11 PST
<rdar://problem/16217977>
Jonathan Wells
Comment 2 2014-03-03 17:11:26 PST
Created attachment 225718 [details] [SCREENSHOT] before patch
Jonathan Wells
Comment 3 2014-03-03 20:35:25 PST
Created attachment 225735 [details] [PATCH] Proposed fix
WebKit Commit Bot
Comment 4 2014-03-03 22:47:17 PST
Comment on attachment 225735 [details] [PATCH] Proposed fix Clearing flags on attachment: 225735 Committed r165039: <http://trac.webkit.org/changeset/165039>
WebKit Commit Bot
Comment 5 2014-03-03 22:47:19 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.