| Summary: | Web Inspector: Match color of regex in source view with a popover | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Wells <jonowells> | ||||||||
| Component: | Web Inspector | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, graouts, joepeck, timothy, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 225718 [details]
[SCREENSHOT] before patch
Created attachment 225735 [details]
[PATCH] Proposed fix
Comment on attachment 225735 [details] [PATCH] Proposed fix Clearing flags on attachment: 225735 Committed r165039: <http://trac.webkit.org/changeset/165039> All reviewed patches have been landed. Closing bug. |
Created attachment 225717 [details] [TEST] popover test case The color for a regular expression in a source popover should be the same orange color that codemirror uses in the source view. * STEPS TO REPRODUCE 1. Open the attached test case 2. Hover variable "regex" which holds a RegExp. => expected color of regexp to be the same orange color as it appears in the source in the assignment on line 7.