[GTK] Give the WebKit GObject DOM bindings API break detection it's own buildbot bubble

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Martin Robinson]

Carlos requested this in 129571.

[Martin Robinson]

Created attachment 225719 [details]
Patch

[Carlos Garcia Campos]

Comment on attachment 225719 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=225719&action=review

Thanks!

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:663
> +    def evaluateCommand(self, cmd):
> +        if self.missingAPI:
> +            return FAILURE
> +        return SUCCESS

I think we can return WARNINGS in case of compatible api changes, so that I won't miss them :-)

[Martin Robinson]

Created attachment 225786 [details]
Return a warning when there is new API

[Martin Robinson]

Created attachment 225798 [details]
Patch

[WebKit Commit Bot]

Attachment 225798 [details] did not pass style-queue:


ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:384:  expected 2 blank lines, found 1  [pep8/E302] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:387:  [RunGtkWebKitGObjectDOMBindingsAPIBreakTestsTest.assertResults] Undefined variable 'SUCCESS'  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:389:  [RunGtkWebKitGObjectDOMBindingsAPIBreakTestsTest.assertResults] Undefined variable 'WARNINGS'  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:391:  [RunGtkWebKitGObjectDOMBindingsAPIBreakTestsTest.assertResults] Undefined variable 'FAILURE'  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:394:  [RunGtkWebKitGObjectDOMBindingsAPIBreakTestsTest.assertResults] Undefined variable 'RunGtkWebKitGObjectDOMBindingsAPIBreakTests'  [pylint/E0602] [5]
Total errors found: 5 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Martin Robinson]

(In reply to comment #5)

> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

The style errors all look like false positives. The tests run fine for me.

[Carlos Garcia Campos]

Comment on attachment 225798 [details]
Patch

I guess it's the same patch, simply adding unit tests

[Martin Robinson]

Comment on attachment 225798 [details]
Patch

Clearing flags on attachment: 225798

Committed r165108: <http://trac.webkit.org/changeset/165108>

[Martin Robinson]

All reviewed patches have been landed.  Closing bug.

[Carlos Garcia Campos]

Was there anything wrong with this patch? I don't see the new step in the bots, should we reopen this? or am I missing something?

[Martin Robinson]

I was hoping that the bots would detect the change to master.cfg and reload, but I guess they did not. Today I'll try to figure out what we need to do to have the bubble show up.