Bug 129633

Summary: Web Inspector: Better Debugger popovers for RegExp values
Product: WebKit Reporter: Jonathan Wells <jonowells>
Component: Web InspectorAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[TEST] test case
none
[PATCH] Proposed fix
none
[SCREENSHOT] popover screenshot none

Jonathan Wells
Reported 2014-03-03 16:03:52 PST
Created attachment 225705 [details] [TEST] test case * SUMMARY Currently debugger popovers for RegExp values appear as full-fledged object graphs. It would be nice to display them more like a string. Compare to the JS Console. * STEPS TO REPRODUCE 1. Open the attached test case. 2. Hover variable "regex" which holds a RegExp. => expected cleaner output like the console / hovering "string"
Attachments
[TEST] test case (435 bytes, text/html)
2014-03-03 16:03 PST, Jonathan Wells 		no flags
Details
[PATCH] Proposed fix (2.19 KB, patch)
2014-03-03 16:10 PST, Jonathan Wells 		no flags
DetailsFormatted DiffDiff
[SCREENSHOT] popover screenshot (31.22 KB, image/png)
2014-03-03 16:35 PST, Jonathan Wells 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-03-03 16:04:29 PST
<rdar://problem/16216851>
Timothy Hatcher
Comment 2 2014-03-03 16:06:58 PST
<rdar://problem/13200695>
Jonathan Wells
Comment 3 2014-03-03 16:10:12 PST
Created attachment 225707 [details] [PATCH] Proposed fix
Timothy Hatcher
Comment 4 2014-03-03 16:15:44 PST
Comment on attachment 225707 [details] [PATCH] Proposed fix Can you attach a screenshot?
Jonathan Wells
Comment 5 2014-03-03 16:35:44 PST
Created attachment 225710 [details] [SCREENSHOT] popover screenshot
Timothy Hatcher
Comment 6 2014-03-03 16:44:05 PST
Comment on attachment 225707 [details] [PATCH] Proposed fix Looks good. We should probably update the color console-formatted-regexp uses to match the orange CodeMirror uses.
Joseph Pecoraro
Comment 7 2014-03-03 16:54:03 PST
(In reply to comment #6) > (From update of attachment 225707 [details]) > Looks good. We should probably update the color console-formatted-regexp uses to match the orange CodeMirror uses. Yeah, I would like that.
Jonathan Wells
Comment 8 2014-03-03 17:13:27 PST
https://bugs.webkit.org/show_bug.cgi?id=129645
WebKit Commit Bot
Comment 9 2014-03-03 17:15:21 PST
Comment on attachment 225707 [details] [PATCH] Proposed fix Clearing flags on attachment: 225707 Committed r165026: <http://trac.webkit.org/changeset/165026>
WebKit Commit Bot
Comment 10 2014-03-03 17:15:24 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.