| Summary: | Web Inspector: Better Debugger popovers for RegExp values | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Wells <jonowells> | ||||||||
| Component: | Web Inspector | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, graouts, joepeck, timothy, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 225707 [details]
[PATCH] Proposed fix
Comment on attachment 225707 [details]
[PATCH] Proposed fix
Can you attach a screenshot?
Created attachment 225710 [details]
[SCREENSHOT] popover screenshot
Comment on attachment 225707 [details]
[PATCH] Proposed fix
Looks good. We should probably update the color console-formatted-regexp uses to match the orange CodeMirror uses.
(In reply to comment #6) > (From update of attachment 225707 [details]) > Looks good. We should probably update the color console-formatted-regexp uses to match the orange CodeMirror uses. Yeah, I would like that. Comment on attachment 225707 [details] [PATCH] Proposed fix Clearing flags on attachment: 225707 Committed r165026: <http://trac.webkit.org/changeset/165026> All reviewed patches have been landed. Closing bug. |
Created attachment 225705 [details] [TEST] test case * SUMMARY Currently debugger popovers for RegExp values appear as full-fledged object graphs. It would be nice to display them more like a string. Compare to the JS Console. * STEPS TO REPRODUCE 1. Open the attached test case. 2. Hover variable "regex" which holds a RegExp. => expected cleaner output like the console / hovering "string"