Bug 129632

Summary:

[iOS WebKit2]: Text fields don't zoom in when focused

Product:

WebKit

Reporter:

Enrica Casucci <enrica>

Component:

WebKit2

Assignee:

Enrica Casucci <enrica>

Status:

RESOLVED FIXED

Severity:

Normal

Keywords:

InRadar

Priority:

Version:

528+ (Nightly build)

Hardware:

iPhone / iPad

OS:

Unspecified

Attachments:

Description	Flags
Patch	benjamin: review+

Description Enrica Casucci 2014-03-03 15:58:35 PST

This can be reproduced with any page that has input elements.

<rdar://problem/16185230>

Comment 1 Enrica Casucci 2014-03-03 16:01:40 PST

Created attachment 225704 [details]
Patch

Comment 2 Benjamin Poulain 2014-03-03 16:23:52 PST

Comment on attachment 225704 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=225704&action=review

> Source/WebKit2/Shared/AssistedNodeInformation.h:97
> +        : minimumScaleFactor(0.1)
> +        , maximumScaleFactor(DBL_MAX)

Maybe -inf and inf instead?

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:416
> +    minimumScrollDistance:0];

The indent is wrong here.

Comment 3 Enrica Casucci 2014-03-03 16:54:35 PST

Committed revision 165022