Bug 129631

Summary: Web Inspector: Avoid too early deref caused by RemoteInspectorXPCConnection::close
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2014-03-03 15:39:46 PST
Overall, the multithreaded aspects of RemoteInspectorXPCConnection are too complicated. This should be simplified in someway. For now, address a couple possible issues: - multithreaded access to m_client (close(), and XPC event handler) - deref too early in close(), if close() is called, we will receive another XPC event (XPC_ERROR) - so deref after we receive the XPC_ERROR event
Attachments
[PATCH] Proposed Fix (7.01 KB, patch)
2014-03-03 16:50 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-03-03 15:40:28 PST
<rdar://problem/16216505>
Joseph Pecoraro
Comment 2 2014-03-03 16:50:15 PST
Created attachment 225713 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 3 2014-03-03 22:52:20 PST
Comment on attachment 225713 [details] [PATCH] Proposed Fix Clearing flags on attachment: 225713 Committed r165040: <http://trac.webkit.org/changeset/165040>
WebKit Commit Bot
Comment 4 2014-03-03 22:52:22 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.