Bug 129631

Summary:

Web Inspector: Avoid too early deref caused by RemoteInspectorXPCConnection::close

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
[PATCH] Proposed Fix	none

Description Joseph Pecoraro 2014-03-03 15:39:46 PST

Overall, the multithreaded aspects of RemoteInspectorXPCConnection are too complicated. This should be simplified in someway. For now, address a couple possible issues:

    - multithreaded access to m_client (close(), and XPC event handler)
    - deref too early in close(), if close() is called, we will receive another XPC event (XPC_ERROR)
      - so deref after we receive the XPC_ERROR event

Comment 1 Radar WebKit Bug Importer 2014-03-03 15:40:28 PST

<rdar://problem/16216505>

Comment 2 Joseph Pecoraro 2014-03-03 16:50:15 PST

Created attachment 225713 [details]
[PATCH] Proposed Fix

Comment 3 WebKit Commit Bot 2014-03-03 22:52:20 PST

Comment on attachment 225713 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 225713

Committed r165040: <http://trac.webkit.org/changeset/165040>

Comment 4 WebKit Commit Bot 2014-03-03 22:52:22 PST

All reviewed patches have been landed.  Closing bug.