Bug 129627

Summary:

Web Inspector: probe sidebar should use overflow:scroll and split space evenly

Product:

WebKit

Reporter:

BJ Burg <bburg>

Component:

Web Inspector

Assignee:

Katie Madonna <madonnk>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, graouts, joepeck, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
sidebar split between two probe sections	none
the patch	none
Patch	none
Probes sidebar with two evenly distributed elements. Minus scrollbar styles.	none
Show collapsed styles for probes sidebar.	none
Patch	none

Description BJ Burg 2014-03-03 15:04:48 PST

Currently, one probe that receives a lot more data will flood out the others making them hard to see.

Comment 1 Radar WebKit Bug Importer 2014-03-03 15:05:32 PST

<rdar://problem/16216007>

Comment 2 Katie Madonna 2014-03-03 15:07:40 PST

Created attachment 225693 [details]
sidebar split between two probe sections

Comment 3 Timothy Hatcher 2014-03-03 15:27:21 PST

What is up with the scrollbars?

Comment 4 BJ Burg 2014-03-03 15:52:56 PST

(In reply to comment #3)
> What is up with the scrollbars?

In the old branch I made them skinnier for the replay drawer's sidebar to save a little space, and apparently copied that idea into the probe sidebar. It can be safely removed.

Comment 5 Katie Madonna 2014-03-03 15:57:58 PST

Created attachment 225703 [details]
the patch

Comment 6 Timothy Hatcher 2014-03-03 16:06:02 PST

(In reply to comment #4)
> (In reply to comment #3)
> > What is up with the scrollbars?
> 
> In the old branch I made them skinnier for the replay drawer's sidebar to save a little space, and apparently copied that idea into the probe sidebar. It can be safely removed.

Yes, lets revert the scrollbar change. People still use the scrollbar to drag with the mouse, and this size is non-standard.

Also revert the whitespace changes in the ChangeLog.

Comment 7 Katie Madonna 2014-03-19 21:25:13 PDT

Created attachment 227251 [details]
Patch

Comment 8 Katie Madonna 2014-03-19 21:28:01 PDT

Created attachment 227252 [details]
Probes sidebar with two evenly distributed elements. Minus scrollbar styles.

Comment 9 Katie Madonna 2014-03-19 21:29:24 PDT

Created attachment 227253 [details]
Show collapsed styles for probes sidebar.

Comment 10 Timothy Hatcher 2014-03-20 11:31:12 PDT

Comment on attachment 227251 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227251&action=review

Some tweaks and questions remain before this should land. But looking good!

> Source/WebInspectorUI/UserInterface/Views/ProbeDetailsSidebarPanel.css:79
> +    min-height: 250px;

What happens if this min-height is triggered? Will that cause double scrollbars? That would be bad.

> Source/WebInspectorUI/UserInterface/Views/ProbeSetDataGrid.css:39
> +.details-section.probe-set .data-grid .data-container {
> +    top: 23px;
> +}

This is a layering violation. details-section is not related and at a higher level than this data grid. This rule should be in ProbeDetailsSidebarPanel.css.

Comment 11 Katie Madonna 2014-03-20 12:10:42 PDT

Created attachment 227314 [details]
Patch

Comment 12 Katie Madonna 2014-03-20 12:12:07 PDT

The min-height did trigger the double scroll bar, so I removed it and moved the CSS rule.

Comment 13 WebKit Commit Bot 2014-03-20 12:47:20 PDT

Comment on attachment 227314 [details]
Patch

Clearing flags on attachment: 227314

Committed r165987: <http://trac.webkit.org/changeset/165987>

Comment 14 WebKit Commit Bot 2014-03-20 12:47:24 PDT

All reviewed patches have been landed.  Closing bug.