Web Inspector: Gradient.js:120:22: JS ERROR: TypeError: undefined is not an object (evaluating 'stop.offset')

• Component: Web Inspector
• Status: RESOLVED FIXED

[Timothy Hatcher]

Seeing Gradient.js:120:22: JS ERROR: TypeError: undefined is not an object (evaluating 'stop.offset') while poking around some internal scripts.

[Radar WebKit Bug Importer]

<rdar://problem/16215772>

[Timothy Hatcher]

The content seems to be:

        var a = "background-image:", b = "gradient(linear,left top,right bottom,from(#9f9),to(white));", c = "linear-gradient(left top,#9f9, white);";

And the components passed to stopsWithComponents are [["left","top"],["#9f9"],["white"]].

[Radar WebKit Bug Importer]

<rdar://problem/16215950>

[Timothy Hatcher]

Found in modernizr-2.0.6.min.js

[Timothy Hatcher]

Created attachment 225694 [details]
Patch

[Joseph Pecoraro]

(In reply to comment #2)
> The content seems to be:
> 
>         var a = "background-image:", b = "gradient(linear,left top,right bottom,from(#9f9),to(white));", c = "linear-gradient(left top,#9f9, white);";
> 
> And the components passed to stopsWithComponents are [["left","top"],["#9f9"],["white"]].

This strikes me as a little weird. The input was "left top", "right bottom". Are we sure we are doing the right thing for these kinds of inputs?

[Joseph Pecoraro]

Comment on attachment 225694 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=225694&action=review

> Source/WebInspectorUI/UserInterface/Models/Gradient.js:192
> +        // We don't support any of the legacy linerar gradient formats.

linerar

[Timothy Hatcher]

Created attachment 225698 [details]
Patch

[Timothy Hatcher]

(In reply to comment #6)
> (In reply to comment #2)
> > The content seems to be:
> > 
> >         var a = "background-image:", b = "gradient(linear,left top,right bottom,from(#9f9),to(white));", c = "linear-gradient(left top,#9f9, white);";
> > 
> > And the components passed to stopsWithComponents are [["left","top"],["#9f9"],["white"]].
> 
> This strikes me as a little weird. The input was "left top", "right bottom". Are we sure we are doing the right thing for these kinds of inputs?

Yeah, the "left" and "top" get sorted and recombined for a switch that looks for "left top". That allows ["top", "left"] to work without the need for case "top left" and all the other permutations.

[WebKit Commit Bot]

Comment on attachment 225698 [details]
Patch

Clearing flags on attachment: 225698

Committed r165017: <http://trac.webkit.org/changeset/165017>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Antoine Quint]

Thanks for cleaning up after me Tim!

[Antoine Quint]

This fix caused https://bugs.webkit.org/show_bug.cgi?id=132083.