Bug 129615
| Summary: | Remove TextTrackCue constructor | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Brendan Long <b.long> |
| Component: | Media | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | ahmad.saleem792, bfulgham, eric.carlson, webkit-bug-importer |
| Priority: | P2 | Keywords: | BrowserCompat, InRadar, WPTImpact |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Brendan Long
We left TextTrackCue's constructor around for legacy reasons when we added VTTCue, but Blink is removing it, so maybe we should too:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/R34xpMQGtXU
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
Blink's Commit - https://chromium.googlesource.com/chromium/blink/+/6ec3aa333b440f18d77baca399b25b43ddab3e1e
By removing following line:
https://searchfox.org/wubkat/source/Source/WebCore/html/track/TextTrackCue.idl#50
We also progress following WPT test case:
https://wpt.fyi/results/html/dom/idlharness.https.html%3Fexclude=(Document%7CWindow%7CHTML.*)?label=master&label=experimental&aligned=&q=safari%3Afail
> TextTrackCue interface object length
Will do PR.
Eric Carlson
(In reply to Ahmad Saleem from comment #1)
> Blink's Commit -
> https://chromium.googlesource.com/chromium/blink/+/
> 6ec3aa333b440f18d77baca399b25b43ddab3e1e
>
> By removing following line:
>
> https://searchfox.org/wubkat/source/Source/WebCore/html/track/TextTrackCue.
> idl#50
>
> We also progress following WPT test case:
>
> https://wpt.fyi/results/html/dom/idlharness.https.
> html%3Fexclude=(Document%7CWindow%7CHTML.
> *)?label=master&label=experimental&aligned=&q=safari%3Afail
>
> > TextTrackCue interface object length
>
> Will do PR.
Removing that will break https://github.com/WebKit/explainers/blob/main/texttracks/README.md
Radar WebKit Bug Importer
<rdar://problem/122587283>