Bug 129614

Summary:

filter-build-webkit should not strip .o

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dino

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
[PATCH] Proposed Fix	none

Description Joseph Pecoraro 2014-03-03 11:51:46 PST

When there is a build error and builds do not stop on the first error then it is very easy to jump from the end "Foo.o failed to compile" up to the error messages by selecting and searching for "Foo.o". Stripping the .o's in the output makes the jump harder.

Do others agree?

Comment 1 Joseph Pecoraro 2014-03-03 11:53:45 PST

Created attachment 225677 [details]
[PATCH] Proposed Fix

Comment 2 WebKit Commit Bot 2014-03-06 18:10:40 PST

Comment on attachment 225677 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 225677

Committed r165238: <http://trac.webkit.org/changeset/165238>

Comment 3 WebKit Commit Bot 2014-03-06 18:10:45 PST

All reviewed patches have been landed.  Closing bug.