Summary: | Rename DEFINE_STATIC_LOCAL to DEPRECATED_DEFINE_STATIC_LOCAL | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sergio Villar Senin <svillar> | ||||||
Component: | Web Template Framework | Assignee: | Sergio Villar Senin <svillar> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | darin, dbates | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 130185 | ||||||||
Attachments: |
|
Description
Sergio Villar Senin
2014-03-03 11:17:28 PST
Created attachment 226533 [details]
Patch
I removed the list of changes in the WebCore ChangeLog because it was huge
BTW I opened bug 130185 to start replacing them with static NeverDestroyed<T> Created attachment 226588 [details]
Patch
Comment on attachment 226588 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226588&action=review Did you use the do-webcore-rename script? It’s really good at doing changes like this one automatically. > Source/WTF/wtf/StdLibExtras.h:38 > -#ifndef DEFINE_STATIC_LOCAL > +#ifndef DEPRECATED_DEFINE_STATIC_LOCAL Should update the comment above to talk about using NeverDestroyed instead. > Tools/DumpRenderTree/JavaScriptThreading.cpp:49 > + DEPRECATED_DEFINE_STATIC_LOCAL(Mutex, staticMutex, ()); Note for the future: I’m surprised we need this at all in test tools. A plain old static should be OK in all the test tool cases. It’s only the frameworks themselves that have the “no static destructor” constraint. > Tools/Scripts/check-for-exit-time-destructors:100 > + print "ERROR: Use DEPRECATED_DEFINE_STATIC_LOCAL from <wtf/StdLibExtras.h>\n"; This is no longer correct advice. The message should mention NeverDestroyed instead. > Tools/TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp:45 > +DEPRECATED_DEFINE_STATIC_LOCAL(String, rootDir, (ASCIILiteral("/"))); Same thought here about test tools not needing this. (In reply to comment #4) > (From update of attachment 226588 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=226588&action=review > > Did you use the do-webcore-rename script? It’s really good at doing changes like this one automatically. Oh, didn't know about it, I just cooked my own. > > Source/WTF/wtf/StdLibExtras.h:38 > > -#ifndef DEFINE_STATIC_LOCAL > > +#ifndef DEPRECATED_DEFINE_STATIC_LOCAL > > Should update the comment above to talk about using NeverDestroyed instead. Good point > > Tools/DumpRenderTree/JavaScriptThreading.cpp:49 > > + DEPRECATED_DEFINE_STATIC_LOCAL(Mutex, staticMutex, ()); > > Note for the future: I’m surprised we need this at all in test tools. A plain old static should be OK in all the test tool cases. It’s only the frameworks themselves that have the “no static destructor” constraint. Yep, I'll open a bug for that. > > Tools/Scripts/check-for-exit-time-destructors:100 > > + print "ERROR: Use DEPRECATED_DEFINE_STATIC_LOCAL from <wtf/StdLibExtras.h>\n"; > > This is no longer correct advice. The message should mention NeverDestroyed instead. Indeed Committed r165607: <http://trac.webkit.org/changeset/165607> |