Bug 129603

Summary: Move EvasGLContext and EvasGLSurface files into the efl common directory.
Product: WebKit Reporter: Hyowon Kim <hw1008.kim>
Component: WebKit EFLAssignee: Hyowon Kim <hw1008.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, cdumez, commit-queue, gyuyoung.kim, gyuyoung.kim, lucas.de.marchi, rakuco, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Linux   
Attachments:
Description Flags
Patch
none
Patch none

Description Hyowon Kim 2014-03-03 04:05:34 PST
EFL port will use EvasGLContext and EvasGLSurface files in both WK1 and WK2.
And WebCore/platform/graphics/efl is more proper place for them.
Comment 1 Hyowon Kim 2014-03-03 04:20:28 PST
Created attachment 225642 [details]
Patch
Comment 2 WebKit Commit Bot 2014-03-03 04:22:46 PST
Attachment 225642 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/efl/EvasGLSurface.h:60:  The parameter name "evasGL" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/graphics/efl/EvasGLContext.h:51:  The parameter name "evasGL" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Hyowon Kim 2014-03-03 05:35:21 PST
Created attachment 225643 [details]
Patch
Comment 4 Gyuyoung Kim 2014-03-03 23:39:12 PST
Comment on attachment 225643 [details]
Patch

LGTM.
Comment 5 WebKit Commit Bot 2014-03-04 00:20:50 PST
Comment on attachment 225643 [details]
Patch

Clearing flags on attachment: 225643

Committed r165043: <http://trac.webkit.org/changeset/165043>
Comment 6 WebKit Commit Bot 2014-03-04 00:20:54 PST
All reviewed patches have been landed.  Closing bug.