Bug 129597

Summary: [x86] Improve code generation of byte test
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, commit-queue, msaboff, oliver, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Benjamin Poulain
Reported 2014-03-02 19:30:55 PST
[x86] Improve code generation of byte test
Attachments
Patch (2.01 KB, patch)
2014-03-02 19:32 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2014-03-02 19:32:25 PST
Created attachment 225628 [details] Patch
Benjamin Poulain
Comment 2 2014-03-02 19:36:11 PST
I have noticed that pattern from the CSS JIT.
Geoffrey Garen
Comment 3 2014-03-03 13:48:58 PST
Comment on attachment 225628 [details] Patch r=me
WebKit Commit Bot
Comment 4 2014-03-03 14:22:41 PST
Comment on attachment 225628 [details] Patch Clearing flags on attachment: 225628 Committed r165009: <http://trac.webkit.org/changeset/165009>
WebKit Commit Bot
Comment 5 2014-03-03 14:22:43 PST
All reviewed patches have been landed. Closing bug.
Benjamin Poulain
Comment 7 2014-03-04 10:36:51 PST
(In reply to comment #6) > Looks like this was a 1% improvement on DYEBench on some machines. > > https://perf.webkit.org/#mode=charts&chartList=%5B%5B%22mac-mavericks%22%2C%22DoYouEvenBench%2FFull%3ATime%3ATotal%22%5D%2C%5B%22mac-mountainlion%22%2C%22DoYouEvenBench%2FFull%3ATime%3ATotal%22%5D%5D That's awesome :)
Note You need to log in before you can comment on or make changes to this bug.