| Summary: | Find results on simple lines are not marked correctly | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | Keywords: | InRadar | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Antti Koivisto
2014-03-02 17:01:37 PST
Created attachment 225657 [details]
patch
Created attachment 225662 [details]
rebased
Comment on attachment 225662 [details] rebased View in context: https://bugs.webkit.org/attachment.cgi?id=225662&action=review r=me > Source/WebCore/editing/TextIterator.cpp:544 > - while (runEnd < str.length() && (deprecatedIsCollapsibleWhitespace(str[runEnd]) || str[runEnd] == '\t')) > + while (runEnd < end && (deprecatedIsCollapsibleWhitespace(str[runEnd]) || str[runEnd] == '\t')) It irks me that we are calling operator[] on WTF::String in a loop instead of at least just operating on the StringImpl, but this is hardly time||place for that kinda cleanup. > Source/WebCore/editing/TextIterator.cpp:1304 > - if (!renderer->firstTextBox() && text.length() > 0) > + if (!renderer->hasRenderedText() && text.length() > 0) We should make the fat linebox getters assert that we are not in simple linebox mode. (Or better yet, abstract away the ability to call them in the wrong context by encapsulating lines.) |