Bug 129582

Summary: Clean up use of Options::enableConcurrentJIT().
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, ggaren, mhahnenberg, mmirman, msaboff, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
the patch. none

Mark Lam
Reported 2014-03-02 14:15:12 PST
DFG Driver was conditionally checking Options::enableConcurrentJIT() only if ENABLE(CONCURRENT_JIT). Otherwise, it bypasses it with a local enableConcurrentJIT set to false. Instead we should configure Options::enableConcurrentJIT() to be false in Options.cpp if !ENABLE(CONCURRENT_JIT), and DFG Driver should always check Options::enableConcurrentJIT(). This makes the code read a little cleaner.
Attachments
the patch. (2.79 KB, patch)
2014-03-02 14:28 PST, Mark Lam 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2014-03-02 14:28:21 PST
Created attachment 225611 [details] the patch.
WebKit Commit Bot
Comment 2 2014-03-02 15:09:11 PST
Comment on attachment 225611 [details] the patch. Clearing flags on attachment: 225611 Committed r164953: <http://trac.webkit.org/changeset/164953>
WebKit Commit Bot
Comment 3 2014-03-02 15:09:15 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.