Bug 129581

Summary: Sort Cocoa platform export files so they merge better
Product: WebKit Reporter: Darin Adler <darin>
Component: Tools / TestsAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: All   
Attachments:
Description Flags
Patch
none
Patch sam: review+, commit-queue: commit-queue-

Darin Adler
Reported 2014-03-02 14:07:39 PST
Sort Mac platform export files so they merge better
Attachments
Patch (85.28 KB, patch)
2014-03-02 14:22 PST, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (78.02 KB, patch)
2014-03-02 14:24 PST, Darin Adler 		sam: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2014-03-02 14:22:42 PST
Created attachment 225609 [details] Patch
Darin Adler
Comment 2 2014-03-02 14:24:50 PST
Created attachment 225610 [details] Patch
WebKit Commit Bot
Comment 3 2014-03-02 14:27:15 PST
Comment on attachment 225610 [details] Patch Rejecting attachment 225610 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 225610, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.appspot.com/results/5278857900851200
Darin Adler
Comment 4 2014-03-02 14:29:56 PST
Committed r164951: <http://trac.webkit.org/changeset/164951>
Tim Horton
Comment 5 2014-03-02 18:56:40 PST
Maybe the style checker should somehow include this?
Darin Adler
Comment 6 2014-03-03 10:50:21 PST
(In reply to comment #5) > Maybe the style checker should somehow include this? Good idea. It would be trivial to add a dry run mode to this tool so that it answers the question, “Would this tool change the file?”
Note You need to log in before you can comment on or make changes to this bug.