Bug 129575

Summary: Support ENABLE_ENCRYPTED_MEDIA in cmake builds
Product: WebKit Reporter: Dirkjan Ochtman <dirkjan>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, commit-queue, eric.carlson, glenn, gyuyoung.kim, jer.noble, philipj, rakuco, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Dirkjan Ochtman
Reported 2014-03-02 08:43:27 PST
Support ENABLE_ENCRYPTED_MEDIA in cmake builds
Attachments
Patch (6.09 KB, patch)
2014-03-02 08:46 PST, Dirkjan Ochtman 		no flags
DetailsFormatted DiffDiff
Patch (6.10 KB, patch)
2014-03-02 09:02 PST, Dirkjan Ochtman 		no flags
DetailsFormatted DiffDiff
Patch (6.99 KB, patch)
2014-03-02 09:10 PST, Dirkjan Ochtman 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Dirkjan Ochtman
Comment 1 2014-03-02 08:46:06 PST
Created attachment 225598 [details] Patch
WebKit Commit Bot
Comment 2 2014-03-02 08:47:39 PST
Attachment 225598 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] ERROR: Source/WebCore/CMakeLists.txt:2579: Alphabetical sorting problem. "html/track/VTTCue.idl" should be before "html/track/VideoTrackList.idl". [list/order] [5] Total errors found: 2 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dirkjan Ochtman
Comment 3 2014-03-02 09:02:32 PST
Created attachment 225599 [details] Patch
WebKit Commit Bot
Comment 4 2014-03-02 09:04:21 PST
Attachment 225599 [details] did not pass style-queue: ERROR: Source/WebCore/CMakeLists.txt:2579: Alphabetical sorting problem. "html/track/VTTCue.idl" should be before "html/track/VideoTrackList.idl". [list/order] [5] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dirkjan Ochtman
Comment 5 2014-03-02 09:10:05 PST
Created attachment 225600 [details] Patch
WebKit Commit Bot
Comment 6 2014-03-02 09:11:06 PST
Attachment 225600 [details] did not pass style-queue: ERROR: Source/WebCore/CMakeLists.txt:2579: Alphabetical sorting problem. "html/track/VTTCue.idl" should be before "html/track/VideoTrackList.idl". [list/order] [5] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Philippe Normand
Comment 7 2014-03-02 09:11:59 PST
Comment on attachment 225600 [details] Patch Thanks!
WebKit Commit Bot
Comment 8 2014-03-02 09:49:52 PST
Comment on attachment 225600 [details] Patch Clearing flags on attachment: 225600 Committed r164943: <http://trac.webkit.org/changeset/164943>
WebKit Commit Bot
Comment 9 2014-03-02 09:49:55 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.