Summary: | Refactor css3/filters/huge-region test | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adenilson Cavalcanti Silva <savagobr> | ||||
Component: | CSS | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, krit, simon.fraser | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 68469 | ||||||
Attachments: |
|
Description
Adenilson Cavalcanti Silva
2014-03-01 13:28:36 PST
Created attachment 226149 [details]
Patch
Comment on attachment 226149 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226149&action=review > LayoutTests/css3/filters/huge-region.html:7 > + width: 4096px; > + height: 4096px; This probably should delayed until we get filter scaling working properly again. But then with much bigger values. Dirk Thanks for the review. The value of 4096px will be big enough to stop the filter execution… but we can use a much bigger value. What would be a limit that would *also* block the execution once we have filter scaling working again? (In reply to comment #3) > Dirk > > Thanks for the review. The value of 4096px will be big enough to stop the filter execution… but we can use a much bigger value. > > What would be a limit that would *also* block the execution once we have filter scaling working again? Anything bigger than 4096 seems fine :) I would like to keep this bug open until we fixed filter scaling and add the blur test to another bug report. Ins't that covered in this bug: https://bugs.webkit.org/show_bug.cgi?id=129555 Comment on attachment 226149 [details] Patch Clearing flags on attachment: 226149 Committed r166089: <http://trac.webkit.org/changeset/166089> All reviewed patches have been landed. Closing bug. |