Bug 129553 – Refactor css3/filters/huge-region test

• Component: CSS
• Status: RESOLVED FIXED

[Adenilson Cavalcanti Silva]

This test uses a blur filter in a huge element which previously wouldn't be filtered at all, it should really become 2 tests: 

a) one for invalid blur values (it uses 2147483648px which will be clamped to 500).
b) another for big regions, it would require to have the following dimensions: 4096x4096 (a bit less if you consider Margin + Border).

[Adenilson Cavalcanti Silva]

Created attachment 226149 [details]
Patch

[Dirk Schulze]

Comment on attachment 226149 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226149&action=review

> LayoutTests/css3/filters/huge-region.html:7
> +      width: 4096px;
> +      height: 4096px;

This probably should delayed until we get filter scaling working properly again. But then with much bigger values.

[Adenilson Cavalcanti Silva]

Dirk

Thanks for the review. The value of 4096px will be big enough to stop the filter execution… but we can use a much bigger value.

What would be a limit that would *also* block the execution once we have filter scaling working again?

[Dirk Schulze]

(In reply to comment #3)
> Dirk
> 
> Thanks for the review. The value of 4096px will be big enough to stop the filter execution… but we can use a much bigger value.
> 
> What would be a limit that would *also* block the execution once we have filter scaling working again?

Anything bigger than 4096 seems fine :) I would like to keep this bug open until we fixed filter scaling and add the blur test to another bug report.

[Adenilson Cavalcanti Silva]

Ins't that covered in this bug:
https://bugs.webkit.org/show_bug.cgi?id=129555

[WebKit Commit Bot]

Comment on attachment 226149 [details]
Patch

Clearing flags on attachment: 226149

Committed r166089: <http://trac.webkit.org/changeset/166089>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.