Bug 129548

Summary:

[Mac] Crash in MediaPlayer::rateChanged()

Product:

WebKit

Reporter:

Jer Noble <jer.noble>

Component:

New Bugs

Assignee:

Jer Noble <jer.noble>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric.carlson, glenn, philipj, sergio

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	darin: review+

Description Jer Noble 2014-03-01 09:50:27 PST

[Mac] Crash in MediaPlayer::rateChanged()

Comment 1 Jer Noble 2014-03-01 09:59:54 PST

Created attachment 225555 [details]
Patch

Comment 2 WebKit Commit Bot 2014-03-01 10:02:53 PST

Attachment 225555 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:117:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:135:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Darin Adler 2014-03-01 16:00:52 PST

Comment on attachment 225555 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=225555&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:2142
> +        if (!weakThis)
> +            return;
> +        function();

This needs a comment. The technique of checking weakThis because we know that’s a precondition for function still being OK to call is subtle. Not the good kind of subtle for programming.

Comment 4 Jer Noble 2014-03-03 12:43:22 PST

Committed r165000: <http://trac.webkit.org/changeset/165000>