Fix srcset related bugs

• Component: New Bugs
• Status: RESOLVED FIXED

[Yoav Weiss]

Fix srcset related bugs

[Yoav Weiss]

Created attachment 225547 [details]
Patch

[WebKit Commit Bot]

Attachment 225547 [details] did not pass style-queue:


ERROR: LayoutTests/ChangeLog:7:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: LayoutTests/ChangeLog:8:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:6:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebCore/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebCore/ChangeLog:10:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 5 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Yoav Weiss]

Created attachment 225548 [details]
Patch

[Andreas Kling]

Comment on attachment 225548 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=225548&action=review

r=me!

> Source/WebCore/html/parser/HTMLParserIdioms.cpp:-401
> -    for (size_t i = 0; i < imageCandidates.size() - 1; ++i) {
> +    for (size_t i = 0; i < imageCandidates.size() - 1; ++i)
>          if (imageCandidates[i].scaleFactor() >= deviceScaleFactor)
>              return imageCandidates[i];
> -    }

WebKit style is to keep the { } braces here since there is more than one line inside the for loop.

[Yoav Weiss]

Created attachment 225570 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 225570 [details]
Patch

Clearing flags on attachment: 225570

Committed r164929: <http://trac.webkit.org/changeset/164929>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Alexey Proskuryakov]

Two tests are crashing after this change:

fast/hidpi/image-srcset-invalid-inputs-except-one.html
fast/hidpi/image-srcset-invalid-inputs.html

http://build.webkit.org/results/Apple%20Mavericks%20Debug%20WK2%20(Tests)/r164933%20(3016)/fast/hidpi/image-srcset-invalid-inputs-except-one-crash-log.txt

[Alexey Proskuryakov]

I'll roll out for now. Please note that there was a build fix, <http://trac.webkit.org/changeset/164934>.

[WebKit Commit Bot]

Re-opened since this is blocked by bug 129570

[Yoav Weiss]

Created attachment 225592 [details]
Patch

[Yoav Weiss]

Fixed the ASSERTs. (removed the ASSERT and added an if instead)

[WebKit Commit Bot]

Comment on attachment 225592 [details]
Patch

Clearing flags on attachment: 225592

Committed r164949: <http://trac.webkit.org/changeset/164949>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.