Bug 129533

Summary: Fix WebKit2 build after r164890
Product: WebKit Reporter: Jinwoo Song <jinwoo7.song>
Component: WebKit Misc.Assignee: Jinwoo Song <jinwoo7.song>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Jinwoo Song 2014-02-28 20:20:34 PST
LayerRepresentation.h is not used in non MAC or IOS port.

[ 83%] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/DrawingAreaProxy.cpp.o
In file included from /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebKit2/UIProcess/DrawingAreaProxy.cpp:31:0:
/mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebKit2/UIProcess/WebPageProxy.h:40:33: fatal error: LayerRepresentation.h: No such file or directory
compilation terminated.
In file included from /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebKit2/UIProcess/WebProcessProxy.h:37:0,
                 from /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebKit2/UIProcess/WebContext.h:45,
                 from /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebKit2/Shared/APIURLRequest.cpp:29:
/mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebKit2/UIProcess/WebPageProxy.h:40:33: fatal error: LayerRepresentation.h: No such file or directory
compilation terminated.
make[2]: *** [Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/DrawingAreaProxy.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: *** [Source/WebKit2/CMakeFiles/WebKit2.dir/Shared/APIURLRequest.cpp.o] Error 1
make[1]: *** [Source/WebKit2/CMakeFiles/WebKit2.dir/all] Error 2
make: *** [all] Error 2
Comment 1 Jinwoo Song 2014-02-28 20:24:06 PST
Created attachment 225528 [details]
Patch
Comment 2 Simon Fraser (smfr) 2014-02-28 20:38:30 PST
Comment on attachment 225528 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=225528&action=review

> Source/WebKit2/ChangeLog:9
> +        but it is not used in non MAC or IOS port.

MAC -> Mac, IOS -> iOS

> Source/WebKit2/UIProcess/WebPageProxy.h:97
> +#if PLATFORM(MAC) || PLATFORM(IOS)

This should be #if PLATFORM(COCOA)
Comment 3 Jinwoo Song 2014-02-28 20:48:33 PST
Created attachment 225532 [details]
Patch

Applied Simon's comments.
Comment 4 WebKit Commit Bot 2014-02-28 21:28:49 PST
Comment on attachment 225532 [details]
Patch

Clearing flags on attachment: 225532

Committed r164909: <http://trac.webkit.org/changeset/164909>
Comment 5 WebKit Commit Bot 2014-02-28 21:28:51 PST
All reviewed patches have been landed.  Closing bug.