Web Inspector: debugger statements do not break

• Component: Web Inspector
• Status: RESOLVED FIXED

[Jonathan Wells]

Created attachment 225512 [details]
Web archive to reproduce the breakpoint bug.

Breakpoints do not seem to work. `debugger;` statements are skipped entirely. Breakpoints inserted in the inspector pretty print editor will not break the execution in WebKit r164860.

To reproduce for the debugger statement:

1. Open the attached breakpoint.webarchive
2. Open the web inspector
3. In the console, call: foo(). 

No breaking will occur.

To reproduce manually:

1. Open the attached breakpoint.webarchive
2. Open the web inspector
3. Click on Resources and open main.js
4. Add a breakpoint inside foo() on line 3 (the variable assignment)
5. Refresh the page.

[Radar WebKit Bug Importer]

<rdar://problem/16202928>

[Mark Lam]

Created attachment 225678 [details]
debugger statement test case

The previously attached test case has a bug where the function containing the debugger statement was never called.  Here's a new one.

[Mark Lam]

Created attachment 225681 [details]
the patch: now supporting debugger statements.

[Mark Lam]

Comment on attachment 225681 [details]
the patch: now supporting debugger statements.

This patch causes many unexpected inspector regressions. Looking into it.

[Mark Lam]

Created attachment 225685 [details]
patch 2

The previous patch has a union - struct tree that is a little too complex.  The result is that the compiler ended up expressing the outermost union as a struct instead.  In patch2, I flattened the union to only contain an unsigned and a struct.  With this, the inspector tests are passing again.

[Geoffrey Garen]

Comment on attachment 225685 [details]
patch 2

r=me

[Mark Lam]

Thanks.  Landed in r165008: <http://trac.webkit.org/r165008>.