| Summary: | [iOS][WebKit2] Don't use any of the mach exception handling code on iOS | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Pratik Solanki <psolanki> | ||||||
| Component: | New Bugs | Assignee: | Pratik Solanki <psolanki> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | andersca, commit-queue, ossy, psolanki | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Pratik Solanki
2014-02-28 16:35:57 PST
Created attachment 225504 [details]
Patch
I could have used #if PLATFORM(MAC) but didn't think having a PLATFORM(MAC) inside a file named Mac.cpp made sense. So I used !PLATFORM(IOS). Created attachment 225508 [details]
Patch
Comment on attachment 225508 [details] Patch Clearing flags on attachment: 225508 Committed r164905: <http://trac.webkit.org/changeset/164905> All reviewed patches have been landed. Closing bug. Comment on attachment 225508 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225508&action=review > Source/WebKit2/Shared/ChildProcessProxy.cpp:131 > -#if PLATFORM(MAC) > +#if !PLATFORM(IOS) It broke the EFL and GTK build. PLATFORM(MAC) was the proper guard here, because only Apple Mac port has/use this function. But !PLATFORM(IOS) includes all ports (Apple Mac, GTK, EFL) except IOS. Buildfix landed in http://trac.webkit.org/changeset/164912 Otherwise I think using !PLATFORM(IOS) instead of PLATFORM(MAC) anywhere is so serious and misleading if you don't want to intentionally refer all ports except IOS. (In reply to comment #2) > I could have used #if PLATFORM(MAC) but didn't think having a PLATFORM(MAC) inside a file named Mac.cpp made sense. So I used !PLATFORM(IOS). PLATFORM(MAC) == Apple Mac port PLATFORM(IOS) == Apple IOS port !PLATFORM(IOS) == all ports except Apple IOS port, which is Apple Mac port if you use it in a *Mac.cpp. But it isn't true in platform independent files. Oops. Do you want to just roll the patch out? I am not near a computer right now. Oh I see you landed a build fix. Thank you! |